|
|
|
|
|
Hi kerwin, In BTF structure, framework's audio service is sending "nugu_playback=on" to Audio hal. Please consider that when receive "nugu_playback=on" in audio hal, switch to PCM. Thank you. |
|
|
Hi Mr. JunGyu Kim, I see there is patch by Amlogic for this behavior. Could you help to confirm with Amlogic Korea? Thank you ! NUGU_AC3_passthrough.png (44,519 bytes) |
|
|
Hi kerwin, I asked the BTFAML-507's patch, there is no action when "skb_bt_voice_state" changed. Additionally, AML korea reviewed INTEK's code. When "nugu_playback=on" comes in, INTEK added some code for additional action. It seems that the manufacturer needs to add code for this issue. Thank you. |
|
|
Hi Kerwin This issue is now divided into two Jira issues. 1) About NUGU at AC3 channel / passthrough mode https://jira.skbroadband.com/browse/BTVD-21643 2) About Google Assistant at AC3 channel / passthrough mode https://jira.skbroadband.com/browse/BTVD-21653 ==> The rule for operation is not defined. please ignore this issue. First, please process NUGU operation only. Thank you YK.Jung |
|
|
Hi kerwin, Please let me know the progress of this issue. Thank you. |
|
|
Hi Mr. JunGyu Kim, I am working on passive standby mode now. I think passive standby mode has higher priority. If I am wrong, please let me know. Thank you ! |
|
|
Hi kerwin, I got it. If any update, please let me know. Thank you. |
|
|
Hi kerwin, Could you resolve this issue until 08/22? Thank you. |
|
|
Hi Mr. JunGyu Kim, I am comparing our log with Intek's. There is a difference in LivePlayer while 'nugu_playback' is changed. Since I don't have source code of LivePlayer, please help to check it with AML Korea RDs. Below is part messages from Intek's log. You can see LivePlayer get notify for NUGU Assistant and pause audio output. Then flush and close AC3 stream. This is not seen on our Smart3 under same condition. You can use "adb logcat | grep onCheckVoiceAssistant" to check it. Thank you ! ================== Intek's log ================================= 07-22 10:21:00.519 3604 6610 I LivePlayer_0: onCheckVoiceAssistant: 0 -> 1 07-22 10:21:00.519 3604 6610 I LivePlayer_0: notify, kWhatPauseOrResumeAudio 07-22 10:21:00.519 3604 6610 I LivePlayer_0: notify: btVoiceState=1 07-22 10:21:00.520 3604 6613 I LivePlayerRenderer_0: [onPauseAudio:2334] 07-22 10:21:00.520 3604 6613 I LivePlayerRenderer_0: onPauseAudio, passthrough only one audiosink permitted 07-22 10:21:00.520 3604 6613 I HalAudioOutput: [pause:181] 07-22 10:21:00.520 3538 3638 D audio_hw_primary: out_pause(0xe71a7180) 07-22 10:21:00.522 3604 6646 I HalAudioOutput: high priority work:0x80000008 07-22 10:21:00.522 3604 6646 I HalAudioOutput: resample thread pause! 07-22 10:21:00.531 3538 3638 E audio_hw_primary: out->pcm and adev->pcm are assumed same handle 07-22 10:21:00.531 3604 6646 I HalAudioOutput: high priority work:0x2 07-22 10:21:00.531 3604 6646 I HalAudioOutput: resample thread flush... 07-22 10:21:00.531 3604 6646 I HalAudioOutput: resample thread flush finished! 07-22 10:21:00.531 3538 3638 D audio_hw_primary: out_flush(0xe71a7180) 07-22 10:21:00.532 3538 3638 I audio_hw_primary: do_output_standby_direct,out 0xe71a7180, out->standby=0 07-22 10:21:00.532 3538 3638 I audio_hw_primary: close alsa device at do_output_standby_direct out->pcm=0xe714a700, open_times=0 07-22 10:21:00.537 3538 3638 I audio_spdif_out: aml_audio_set_spdif_format tinymix AML_MIXER_ID_SPDIF_FORMAT 0 07-22 10:21:00.537 3538 3638 I audio_hwsync: aml_audio_hwsync_init done 07-22 10:21:00.537 3604 6613 D HalAudioOutput: [~HalAudioOutput:63] 07-22 10:21:00.538 3538 3637 D audio_hw_primary: adev_set_parameters(0xe7175100, hal_audio_state=off) 07-22 10:21:00.538 3538 3637 I audio_hw_primary: adev_set_parameters(kv: hal_audio_state=off) 07-22 10:21:00.538 3538 3637 I audio_hw_primary: adev_set_parameters, ret=3, value=off 07-22 10:21:00.538 3538 3637 I audio_hw_primary: adev_set_parameters, value=off, adev->hal_audio_open_times=0 07-22 10:21:00.538 3538 3637 I audio_hw_primary: Amlogic_HAL - adev_set_parameters: return 0 instead of length of data be copied. 07-22 10:21:00.538 3604 6613 I AmlAudioOutPort: setParameters:hal_audio_state=off, err=0 07-22 10:21:00.538 3604 6613 I HalAudioOutput: resample thread exiting... 07-22 10:21:00.538 3604 6646 I HalAudioOutput: high priority work:0x1 07-22 10:21:00.538 3604 6646 I HalAudioOutput: quit resample thread exit! 07-22 10:21:00.539 3604 6613 I HalAudioOutput: resample thread exited! 07-22 10:21:00.539 3604 6613 D HalAudioOutput: [~HalAudioOutput:72], exit 07-22 10:21:00.540 3604 6613 D MiniAudioSink: [~MiniAudioSink:78] 07-22 10:21:00.540 3604 6613 I LivePlayerClock_0: [AudioClock] setStartingTimeMedia:-0.000001, nowUs:129.196273 07-22 10:21:00.541 3604 6610 I LivePlayerRenderer_0: [setMuteEnable:434] setMuteEnable:1, mPassthroughSetting=1 07-22 10:21:00.541 3604 6610 I LivePlayer_0: [onPauseAudio:3223] pause audio, trackIndex:1 07-22 10:21:00.541 3604 6610 I LivePlayer_0: [onSelectTrack:3331] onSelectTrack: trackIndex:1, pid:-1, select:0 07-22 10:21:00.541 3538 3638 D audio_hw_primary: adev_close_output_stream_new: enter usecase = [3]RAW_DIRECT 07-22 10:21:00.541 3538 3638 D audio_hw_primary: adev_close_output_stream: enter: dev(0xe7175100) stream(0xe71a7180) 07-22 10:21:00.541 3538 3638 D audio_hw_primary: out_standby_new: enter 07-22 10:21:00.541 3538 3638 I audio_hw_primary: [do_output_standby_l:6672] stream usecase:[3]RAW_DIRECT , continuous:0 07-22 10:21:00.541 3538 3638 I audio_hw_primary: ++[usecase_change_validate_l:9388], dev masks:0x1, is_standby:1, out usecase:[3]RAW_DIRECT 07-22 10:21:00.541 3538 3638 I audio_hw_primary: enable rawtopcm_flag !!! 07-22 10:21:00.541 3538 3638 I audio_hw_primary: --[usecase_change_validate_l:9403], dev masks:0x1, is_standby:1, out usecase [3]RAW_DIRECT 07-22 10:21:00.541 3538 3638 I audio_hw_primary: do_output_standby_l current usecase_masks 1 07-22 10:21:00.541 3538 3638 D audio_hw_primary: out_standby_new: exit 07-22 10:21:00.541 3538 3638 I audio_hw_primary: enable rawtopcm_flag 07-22 10:21:00.541 3538 3638 I audio_hwsync: aml_audio_hwsync_release done 07-22 10:21:00.541 3538 3638 D audio_hw_primary: adev_close_output_stream: exit 07-22 10:21:00.541 3538 3638 D audio_hw_primary: adev_close_output_stream_new: exit |
|
|
Hi kerwin, This is AML Korea's response. ================================================== 1. LivePlayer_0: onCheckVoiceAssistant is skb_bt_voice_state in audio_hw.c. 2. When active NUGU, skb_bt_voice_state is not update. ================================================== I reviewed audio_hw.c and it doesn't change skb_bt_voice_state here. ================================================== if(true == set_aud_output){ ALOGI("%s() audio_control_mode: %x, audio_output_type: %x\n", __func__, audio_control_mode, audio_output_type); set_hdmi_audio_output(adev); goto exit; <<-- Cause by this code. } ... // Not entered here. ret = str_parms_get_str (parms, "nugu_playback", value, sizeof (value) ); if (ret >= 0) { if (strcmp (value, "on") == 0) { adev->skb_bt_voice_state = true; } else { adev->skb_bt_voice_state = false; } goto exit; } ================================================== Please check it. Thanks. |
|
|
Hi Mr. JunGyu Kim, After I correct 'skb_bt_voice_state' state in audio_hw.c, issue is solved. Should I commit it to 5.3.4 branch or wait for 5.3.5 ? Please let me know, thank you ! |
|
|
Hi kerwin, Please commit this modification to 5.3.4 branch. Thank you for your supprot. Kim |
|
|
Committed to BFX-AT100_5.3.4 |
|
|
Hi kerwin, After apply commit, this issue has been clear. Thank you for your support. Please also commit this modification to UHD4 branch (5.3.4). |
|
|
already push patch to UHD4 5.3.4 branch BTVD-21643.png (39,258 bytes) |
|
|
I got it. Thank you! |
|
|
Hi Kerwin, This issue is occurring in ATV12. I verified the code between ATV10 and ATV12, this modification is not applied in ATV12. Please commit this modification to ATV12. Thank you Kim |
|
|
applied patch to ATV12 |
|
|
Hi Kerwin, After applying this patch, NUGU is behaving strangely. So please remove this patch in ATV12. I will make new mantis ticket for ATV12. Thank you Kim |
|
|
Hi JunGyu Kim, It is reverted from BitBucket. Thank you ! |
|
|
Hi Kerwin, Thank you for support. I close this issue. Kim |
- yk.jung ( (ALTech) Younkwang Jung ) developer
